#2530 Fix StringLogAppender leaks for MockHandler

The StringBuilder object inside StringLogAppender has never be called collect() to de-refer all the string objects. it leads memory leak on long running mock server
karatelabs · Jul 15, 2024 · 52c3124 · 52c3124
1 parent e4c8cac
commit 52c3124
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 6 deletions.
diff --git a/karate-core/src/main/java/com/intuit/karate/Logger.java b/karate-core/src/main/java/com/intuit/karate/Logger.java
@@ -48,6 +48,8 @@ public class Logger {
 
     private boolean appendOnly;
 
+    private boolean logOnly;
+
     public void setAppender(LogAppender appender) {
         this.appender = appender;
     }
@@ -68,6 +70,14 @@ public boolean isAppendOnly() {
         return appendOnly;
     }
 
+    public void setLogOnly(boolean logOnly) {
+        this.logOnly = logOnly;
+    }
+
+    public boolean isLogOnly() {
+        return logOnly;
+    }
+
     public Logger(Class clazz) {
         LOGGER = LoggerFactory.getLogger(clazz);
     }
@@ -85,7 +95,9 @@ public void trace(String format, Object... arguments) {
             if (!appendOnly) {
                 LOGGER.trace(format, arguments);
             }
-            formatAndAppend(format, arguments);
+            if (!logOnly) {
+                formatAndAppend(format, arguments);
+            }
         }
     }
 
@@ -94,7 +106,9 @@ public void debug(String format, Object... arguments) {
             if (!appendOnly) {
                 LOGGER.debug(format, arguments);
             }
-            formatAndAppend(format, arguments);
+            if (!logOnly) {
+                formatAndAppend(format, arguments);
+            }
         }
     }
 
@@ -103,7 +117,9 @@ public void info(String format, Object... arguments) {
             if (!appendOnly) {
                 LOGGER.info(format, arguments);
             }
-            formatAndAppend(format, arguments);
+            if (!logOnly) {
+                formatAndAppend(format, arguments);
+            }
         }
     }
 
@@ -112,7 +128,9 @@ public void warn(String format, Object... arguments) {
             if (!appendOnly) {
                 LOGGER.warn(format, arguments);
             }
-            formatAndAppend(format, arguments);
+            if (!logOnly) {
+                formatAndAppend(format, arguments);
+            }
         }
     }
 
@@ -121,7 +139,9 @@ public void error(String format, Object... arguments) {
             if (!appendOnly) {
                 LOGGER.error(format, arguments);
             }
-            formatAndAppend(format, arguments);
+            if (!logOnly) {
+                formatAndAppend(format, arguments);
+            }
         }
     }
 

diff --git a/karate-core/src/main/java/com/intuit/karate/core/MockHandler.java b/karate-core/src/main/java/com/intuit/karate/core/MockHandler.java
@@ -116,7 +116,8 @@ private ScenarioRuntime initRuntime(Feature feature, Map<String, Object> args) {
         section.setIndex(-1); // TODO util for creating dummy scenario
         Scenario dummy = new Scenario(feature, section, -1);
         section.setScenario(dummy);
-        ScenarioRuntime runtime = new ScenarioRuntime(featureRuntime, dummy);        
+        ScenarioRuntime runtime = new ScenarioRuntime(featureRuntime, dummy);
+        runtime.logger.setLogOnly(true);
         runtime.engine.setVariable(PATH_MATCHES, (Function<String, Boolean>) this::pathMatches);
         runtime.engine.setVariable(PARAM_EXISTS, (Function<String, Boolean>) this::paramExists);
         runtime.engine.setVariable(PARAM_VALUE, (Function<String, String>) this::paramValue);