Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javafx on java 11 #656

Closed
shiluka opened this issue Jan 23, 2019 · 5 comments
Closed

javafx on java 11 #656

shiluka opened this issue Jan 23, 2019 · 5 comments
Assignees

Comments

@shiluka
Copy link
Contributor

shiluka commented Jan 23, 2019

Can not build intuit/karate on java 11.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.0:testCompile (default-testCompile) on project karate-junit4: Compilation failure
[ERROR] /home/dev/projects/karate/karate/karate-junit4/src/test/java/com/intuit/karate/junit4/demos/UiRunner.java:[14,12] cannot access javafx.application.Application
[ERROR] class file for javafx.application.Application not found

@shiluka
Copy link
Contributor Author

shiluka commented Jan 23, 2019

oracle has removed javaFX form Java Development Kit (JDK) 11, hence need to provide dependency on javafx-controls module. I have added the dependency on pom.xml as a fix and will send the pull request.

    `<dependency>
        <groupId>org.openjfx</groupId>
        <artifactId>javafx-controls</artifactId>
        <version>12-ea+9</version>
    </dependency>`

shiluka added a commit to shiluka/karate that referenced this issue Jan 23, 2019
@ptrthomas ptrthomas added the bug label Jan 23, 2019
ptrthomas added a commit that referenced this issue Jan 23, 2019
added dependency javafx-controls for java 11 #656
@ptrthomas
Copy link
Member

@shiluka thanks ! looks good.

one observation is that the "fatjar" size is now 25 MB instead of 17 MB. I guess it is not too bad :|

I also notice the log has stopped appearing in the textarea in the UI - hope someone can take a look

I guess the JAR may become a little more bigger when we use GraalVM, ref #646

@babusekaran
Copy link
Contributor

@ptrthomas observed the logging issue after 0.9.1 itself.

@ptrthomas
Copy link
Member

@babusekaran thanks, that is what I thought. needs fixing.

@ptrthomas ptrthomas added this to the 0.9.2 milestone Mar 11, 2019
@ptrthomas
Copy link
Member

released 0.9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants