Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Spring Boot 2.3.4 for Demo project #1301

Merged

Conversation

sixdouglas
Copy link

Description

This PR is to upgrade the Spring Boot version used for the demo project.

  • Relevant Issues :

As you can see, in the following files :

karate-demo/src/test/java/demo/error/no-url.feature
karate-demo/src/test/java/demo/headers/content-type.feature

I've removed the test looking for charset=UTF-8, since Spring Consider this as the default value and marked his MediaType#APPLICATION_JSON_UTF8 as deprecated ( See here ). As compiler is launched with the -Werror flag, forcing the server to send this header, would fail the build.

  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

@sixdouglas
Copy link
Author

Happy #hacktoberfest

@ptrthomas
Copy link
Member

@sixdouglas this is great, thanks. the build does seem to have failed, hopefully just a minor tweak away: https://travis-ci.org/github/intuit/karate/builds/732896653

image

Copy link
Member

@ptrthomas ptrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sixdouglas
Copy link
Author

sixdouglas commented Oct 5, 2020

I'm building the project using this command:

mvn clean package -P pre-release -Dmaven.javadoc.skip=true -B -V -Djavacpp.platform=linux-x86_64

I'm running the Build locally and it fails in the karate-robot module with this:

[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.12 s <<< FAILURE! - in com.intuit.karate.robot.OpenCvUtilsTest
[ERROR] testOpenCv(com.intuit.karate.robot.OpenCvUtilsTest)  Time elapsed: 0.12 s  <<< ERROR!
java.lang.UnsatisfiedLinkError: no jniopenblas_nolapack in java.library.path
	at com.intuit.karate.robot.OpenCvUtilsTest.testOpenCv(OpenCvUtilsTest.java:22)
Caused by: java.lang.UnsatisfiedLinkError: no openblas_nolapack in java.library.path
	at com.intuit.karate.robot.OpenCvUtilsTest.testOpenCv(OpenCvUtilsTest.java:22)

But there are no error in the karate-demo module.
Do you have any idea on how I can fix this issue?

Otherwise, the build run successfully without the -Djavacpp.platform=linux-x86_64 option

@ptrthomas
Copy link
Member

I retried on CI still failed. but no worries, let me investigate locally

@ptrthomas ptrthomas merged commit 0d8b888 into karatelabs:develop Oct 5, 2020
@ptrthomas
Copy link
Member

@sixdouglas my bad - there was an issue introduced in #1299 which I somehow missed. all good now - thanks again ! and happy #hacktoberfest :)

@sixdouglas
Copy link
Author

Nice Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants