#1165 - filter expired cookies when injected in httpClient #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ptrthomas - opened this PR for #1165 - filter expired cookies when injected in httpClient. Let me know for any feedback. Thank you. |
|
@chaudharydeepak this is good work ! thanks 👍 |
|
@chaudharydeepak in case you have used cookies for UI testing in karate - do take a look at this one: #1293 |
|
@ptrthomas Thank you! I am not too familiar with UI testing - though I am definitely interested in workimg on this - I can figure it out & will ask questions if I have any. If its ok, please assign #1293 to me & I will get start. |
|
@chaudharydeepak great, thanks - I also saw this other one if you prefer that: #1211 either way, for some reason I can't assign it to you until you make a comment on the issue directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1165 - filter expired cookies when injected in httpClient
Includes fixes to remove expired cookies using httpClient. Fix is implemented both for jersey as well as apache clients.