Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : Bump up Gatling version #1335

Merged
merged 1 commit into from
Oct 17, 2020
Merged

feat : Bump up Gatling version #1335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions karate-gatling/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<dependency>
<groupId>io.gatling.highcharts</groupId>
<artifactId>gatling-charts-highcharts</artifactId>
<version>3.0.2</version>
<version>3.4.0</version>
</dependency>
<dependency>
<groupId>org.scala-lang</groupId>
Expand Down Expand Up @@ -79,7 +79,7 @@
<plugin>
<groupId>io.gatling</groupId>
<artifactId>gatling-maven-plugin</artifactId>
<version>3.0.1</version>
<version>3.1.0</version>
<configuration>
<disableCompiler>true</disableCompiler>
<skip>${skipTests}</skip>
Expand Down
2 changes: 1 addition & 1 deletion karate-gatling/src/main/scala/com/intuit/karate/gatling/KarateAction.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class KarateAction(val name: String, val tags: Seq[String], val protocol: Karate
override def reportPerfEvent(event: PerfEvent): Unit = {
val okOrNot = if (event.isFailed) KO else OK
val message = if (event.getMessage == null) None else Option(event.getMessage)
statsEngine.logResponse(session, event.getName, event.getStartTime, event.getEndTime, okOrNot, Option(event.getStatusCode + ""), message)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally: glad to see that someone else understands this code

statsEngine.logResponse(session.scenario, List.empty, event.getName, event.getStartTime, event.getEndTime, okOrNot, Option(event.getStatusCode + ""), message)
}

}
Expand Down
2 changes: 1 addition & 1 deletion karate-gatling/src/main/scala/com/intuit/karate/gatling/KarateProtocol.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@ object KarateProtocol {
}

case class KarateComponents(val protocol: KarateProtocol, val system: ActorSystem) extends ProtocolComponents {
override def onStart: Session => Session = ProtocolComponents.NoopOnStart
override def onStart: Session => Session = Session.Identity
override def onExit: Session => Unit = ProtocolComponents.NoopOnExit
}