Firefoxdocker 1337 #1347
Merged
Firefoxdocker 1337 #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft - Made changes for FireFox docker for UI test - currently works with geckodriver. Changes to continue for more cleaner / robust approach - possibly include playwrightdriver for cross-browser testing rather than individual chrome / FireFox etc. corresponding driver. |
ptrthomas
approved these changes
Oct 23, 2020
|
@chaudharydeepak this is great - that we have 2 docker containers. thanks ! I'll merge and test later. in future we can look to centralize some of the common code, but certainly not a priority |
|
@ptrthomas - sure thing, Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1337 Firefox docker for UI testing