Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also send session groups when logging Gatling event #1468

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Also send session groups when logging Gatling event #1468

merged 1 commit into from
Feb 3, 2021

Conversation

pcbue
Copy link
Contributor

@pcbue pcbue commented Feb 3, 2021

Description

Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the develop branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

  • Relevant Issues : Enhancement: log groups in perf events #1467
  • Relevant PRs : (optional)
  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

@ptrthomas ptrthomas merged commit 048f79e into karatelabs:develop Feb 3, 2021
@ptrthomas
Copy link
Member

@pcbue thank you for this. LGTM but I'd like to summon @theathlete3141 to have a look in case this has any other impact

@theathlete3141
Copy link

I wasn't actually aware of the "groups" functionality in Gatling, but this looks right. I expect that session.groups is just an empty list if you don't make use of groups when creating the scenario.

@ptrthomas
Copy link
Member

thanks @theathlete3141 let me loop in @sixdouglas as I just remembered he is familiar with this part of the code as well

@pcbue
Copy link
Contributor Author

pcbue commented Feb 3, 2021

I expect that session.groups is just an empty list if you don't make use of groups when creating the scenario.

Yes, indeed, session.groups resolve to Nil (== List.empty) if not used (or no groups still encountered) in the scenario

@sixdouglas
Copy link

It seems for me too.
Didn't know Gatling group functionality either, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants