Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1502 #1508

Merged
merged 10 commits into from
Mar 10, 2021
Merged

Issue 1502 #1508

merged 10 commits into from
Mar 10, 2021

Conversation

joelpramos
Copy link
Contributor

Description

Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the develop branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

- adding beforeBackground() and afterBackground()
…essing

- fixing background section in dynamic outline still being executed if beforeFeature() evaluates to false
- fixing missing parsing/selecting of Examples Table by tags
…enario run of a Dynamic Outline (background or not) and previously was only true for backgroudn section. ScenarioRuntime.isDynamicBackground() should now be used instead.
…ious commit:

- if running Feature without a tag selector, it will combine all the Examples tables together (tagged or non tagged)
- if running Feature with a tag selector and there is at least one Examples table with a tag, only the examples that match the tag selector will be selected
@joelpramos
Copy link
Contributor Author

@ptrthomas @ivangsa ready to review.

summary of the implementation regarding the usage of tags in the Examples Table (added a short note in the docs as well):

  • if running Feature without a tag selector, it will combine all the Examples tables together (tagged or non tagged)
  • if running Feature with a tag selector and there is at least one Examples table with a tag, only the examples that match the tag selector will be selected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants