-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1502 #1508
Merged
Merged
Issue 1502 #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adding beforeBackground() and afterBackground()
…essing - fixing background section in dynamic outline still being executed if beforeFeature() evaluates to false
- fixing missing parsing/selecting of Examples Table by tags
…enario run of a Dynamic Outline (background or not) and previously was only true for backgroudn section. ScenarioRuntime.isDynamicBackground() should now be used instead.
…ious commit: - if running Feature without a tag selector, it will combine all the Examples tables together (tagged or non tagged) - if running Feature with a tag selector and there is at least one Examples table with a tag, only the examples that match the tag selector will be selected
@ptrthomas @ivangsa ready to review. summary of the implementation regarding the usage of tags in the Examples Table (added a short note in the docs as well):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the
develop
branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.