Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[karate-core] Error in the calculation of the position of an element … #1590

Merged

Conversation

arthur25000
Copy link

#1583

  • update README

Description

Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the develop branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

@ptrthomas ptrthomas merged commit 48ac794 into karatelabs:develop May 10, 2021
@joelpramos
Copy link
Contributor

joelpramos commented May 10, 2021

@arthur25000 @ptrthomas does the move() method work using the absolute or relative position of the page? I'm assuming absolute as I believe we previously used it in conjunction with position().

@arthur25000
Copy link
Author

@joelpramos Sorry for the late reply. I missed your comment.

I am not absolutely sure as I don't use this method but from what I can see, the mouse().move() calls chrome Input.dispatchMouseEvent : https://chromedevtools.github.io/devtools-protocol/tot/Input/#method-dispatchMouseEvent

From the documentation, the coordinates passed in parameters are relative to the current view port.

@arthur25000 arthur25000 deleted the fix_element_position_calculation branch May 21, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants