Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2291 #2462

Merged
merged 4 commits into from
Dec 16, 2023
Merged

#2291 #2462

merged 4 commits into from
Dec 16, 2023

Conversation

f-delahaye
Copy link
Contributor

Description

  • added documentation for new karate-playwright module. Feel free to improve and/or correct syntax if needed!
    The old Playwright section has been retained and renamed as Playwright legacy, not sure what the plans are for it - last time I tried, it could not even connect to PW due to changes in their protocol. Pretty easy to fix though.

  • fixed syntax error with exists({}Foo) reported in explore adding first-class support for playwright #2291

  • fixed timeout issue potentially reported in explore adding first-class support for playwright #2291 (not sure as no reproducer was provided)

  • fixed Driver.intercept (I guess the API has changed since the initial commit)

  • minor other refactoring.

  • Relevant Issues : explore adding first-class support for playwright #2291

  • Type of change :

    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

@f-delahaye
Copy link
Contributor Author

f-delahaye commented Dec 10, 2023

@ptrthomas Test passes locally but not in github. Not sure if it's a bug, or just different configurations...
It relies on elapsed times and timeouts so its flacky by nature, but still, I wasn't expecting this. Would you be able to run it locally, by any chance?

@ptrthomas
Copy link
Member

ptrthomas commented Dec 10, 2023

@f-delahaye I see a CI error

(edit) nevermind, just saw your comment. will investigate

@ptrthomas ptrthomas merged commit 04abc9b into karatelabs:develop Dec 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants