Issue-479: karate-ui enhanced to create-new/edit-existing/save-modified features

[vmchukky]

Description

Added support in karate-ui for

1. creating new features (with a sample template initially saved to a temporary noname.feature)
2. edit existing features (both in Raw-Content area, and also in the text area of individual Steps)
3. save currently loaded feature
4. save imported postman collection into a temporary noname.feature which can be viewed, edited and saved as feature file of choice
5. fixed a minor issue with off-by-one error in FeatureWrapper (https://github.com/vmchukky/karate/blob/Issue-479/karate-core/src/main/java/com/intuit/karate/cucumber/FeatureWrapper.java#L94-L95) which was causing removal of last line from feature each time joinLines(int startLine, int endLine) is invoked

Note:

1. To add new steps one has to add text in Raw-Content area (corresponding Steps will be automatically added below, only after losing focus from Raw-Content area)
2. After updating the feature (either in Raw-Content area or in TextArea of individual steps) one has to trigger focus-lost from that TextArea for the UI to take the modification (please do this, clicking in some other part of the UI, before trying to save the changes)

• Relevant Issues : karate-ui enhancements part 1 #479
• Relevant PRs : (optional)
• Type of change :
  • New feature
  • Bug fix for existing feature
  • Code quality improvement
  • Addition or Improvement of tests
  • Addition or Improvement of documentation

[ptrthomas]

fantastic ! thank you good sir

[vmchukky]

@ptrthomas thank you for taking the patch, regarding the pending issue from your list

Currently the threading model needs work, the status of step execution reflects only at the end of ALL steps. needs to be fixed

I will raise another PR with a fix for this, couldn't finish testing different scenarios last night and hoping to wrap it up tonight.

BTW, had a quick glance at 99a2843, engine-rewrite-exit-cucumber is taking a good shape. IMO, lets leave karate-ui as-is until you are done with this big ticket item. Let me know if you have any other help wanted items related to #444 or any other pending items.

[ptrthomas]

@vmchukky thank you so much. been waiting for some love to go into the UI - it has so much potential - and finally.

you can think through if you want to re-design parts of the UI. here's one of the old conversations:
#325 (comment)

here's a few more notes I made that may be raw, but you can see what you think:

• Karate has a "call" syntax that calls another feature. when this happens, can we "drill down". I'm ok if the approach is to "spawn" another instance of the appropriate Panel
• there are some gaps (I think) in the handling / editability of a) large "docstring" sections (the multi-line values in triple quotes) and Cucumber tables
• may be nice to see Cucumber tables as editable grids

[ptrthomas]

@vmchukky just realized you are offering help on # 444 also - great - let me think through while I work through the remaining part

meanwhile, based on past experience I think your commits may not show up under "contributors" (once we merge to master) because of this: https://help.github.com/articles/why-are-my-contributions-not-showing-up-on-my-profile/#you-havent-added-your-local-git-commit-email-to-your-profile

because when I look at the commit log, your entries have the logo grayed out and your username is not click-able: https://github.com/intuit/karate/commits/develop

[vmchukky]

based on past experience I think your commits may not show up under "contributors" (once we merge to master) because of this: https://help.github.com/articles/why-are-my-contributions-not-showing-up-on-my-profile/#you-havent-added-your-local-git-commit-email-to-your-profile

Thanks @ptrthomas for pointing this out, I have added git-commit-email to my git profile (as secondary) and now the logo appears in https://github.com/intuit/karate/commits/develop (and https://github.com/intuit/karate/commits/develop?author=vmchukky also shows my commits), will fix my gitconfig to use my primary email going forward.