Handle corner cases such as lines with single characters or lines beginning with J
#1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation chokes when a line starts with a capital
J
, and skips lines that consist of only a single character.I have added a test with some corner cases I thought of, but was only able to handle them by manually checking for newlines (you can see that
extras
is set to[]
now), as thetext
would otherwise end up with newlines in them when parsing single characters.In the repo description it says that this is a mirror of the sourcehut version, but I did not find a mailing list on the sourcehut to send patches to (https://lists.sr.ht/~kareigu/tree-sitter-jjdescription gives 404). If there is some other way to contribute other than through GitHub pull requests, please let me know!