Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add disable-renderer-backgrounding flag #124

Conversation

cexbrayat
Copy link
Contributor

Fixes #123

@rogeriopvl
Copy link
Collaborator

@cexbrayat thanks for the PR.

From what I understand, it should be enough to just use the --disable-background-timer-throttling flag, but on OSX it's not and it needs the --disable-renderer-backgrounding to completely disable that behaviour. Is it correct? If it is, then we need a comment documenting this work around.

I've been able to run a test suite with this flag and can confirm that there are performance gains that justify merging this.

@cexbrayat cexbrayat force-pushed the feat/disable-renderer-backgrounding branch from 5d19ff8 to 6bfc170 Compare May 5, 2017 12:32
@cexbrayat
Copy link
Contributor Author

@rogeriopvl Thank you for considering this. You're correct, this only improves performance on OSX (https://bugs.chromium.org/p/chromium/issues/detail?id=605498#c1 is probably the Chrome related issue).

I added a comment to document the workaround, let me know if that's enough.

@rogeriopvl
Copy link
Collaborator

@cexbrayat looks good 👍

@rogeriopvl rogeriopvl merged commit 0db9489 into karma-runner:master May 5, 2017
@rogeriopvl
Copy link
Collaborator

@dignifiedquire we should do a patch release

@dignifiedquire
Copy link
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants