Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suite (package) name is not prepended to the classname attribute in the testcase element #179

Closed
danlz opened this issue Feb 5, 2020 · 0 comments · Fixed by #184
Closed

Suite (package) name is not prepended to the classname attribute in the testcase element #179

danlz opened this issue Feb 5, 2020 · 0 comments · Fixed by #184

Comments

@danlz
Copy link

danlz commented Feb 5, 2020

If you set the suite property in the config, then this value is not prepended to the classname attribute in the testcase element.

karma-junit-reporter/index.js

Line 144 in 2f43e50

name += '.'

This line should probably be:
name += pkgName + '.'

Currently the workaround is to use the classNameFormatter function to customize the classname attribute.
@danlz danlz changed the title Suite (package) name is not written to the classname attribute in the testcase element Suite (package) name is not prepended to the classname attribute in the testcase element Feb 5, 2020
@barclay-reg barclay-reg mentioned this issue Mar 27, 2020
Closed
@jason-ha jason-ha mentioned this issue Sep 2, 2020
Merged
joeyparrish pushed a commit that referenced this issue Oct 7, 2020
@jason-ha
fix: restore suite in classname for old XML (#184)
afa7ca1 
Fix #179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: restore suite in classname for old XML jason-ha/karma-junit-reporter
1 participant
@danlz