Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary nulling out of suites #110

Merged
merged 1 commit into from
Dec 1, 2016

Conversation

thatmarvin
Copy link
Contributor

When a watcher triggers Karma to re-run a test, onRunComplete() from
the first test run happens after onRunStart() from the second test run.
This results in suites incorrectly clobbered to null.

Nulling it out is unnecessary as long as onRunStart() initializes
suites.

Fixes #99.

When a watcher triggers Karma to re-run a test, onRunComplete() from
the first test run happens after onRunStart() from the second test run.
This results in `suites` incorrectly clobbered to null.

Nulling it out is unnecessary as long as onRunStart() initializes
`suites`.

Fixes karma-runner#99.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@thatmarvin
Copy link
Contributor Author

CLA is signed

@googlebot
Copy link

CLAs look good, thanks!

@dignifiedquire dignifiedquire merged commit 4202ee8 into karma-runner:master Dec 1, 2016
@dignifiedquire
Copy link
Member

Thank you :octocat:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants