Initialize var suites early

[randakar]

As #61 (comment)
Minor cleanup. Doing it this way should be faster though (no constructor call overhead, less code to begin with).

Credit goes to https://github.com/robinj for this one. I just implemented it.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[randakar]

I signed it.

[googlebot]

CLAs look good, thanks!

[robinj]

Looks good to me

[dignifiedquire]

Are you sure you can remove the init from run_start? This way if there are multiple runs it does not get reset

[dignifiedquire]

I'm especially thinking about runs with autoWatch: true

[randakar]

The reset is exactly what was causing issues. In some cases the onRunComplete() event would reset the suites object (set it to null) and then a different run (that was running simultaneously) would access it. Kaboom.

See the commit merged to the tip of master - there's a reason that is done.
I have made a second pull request that nulls the individual suite stored in the suites object when the run ends. That way memory is still cleared after each run (hopefully preventing a massive leak).

[dignifiedquire]

Thanks

[randakar]

As an aside, I'm pretty sure a casual look at other reporters would show a repeat of this exact same pattern.

The only one I have in our builds is the Jenkins reporter, and that one does this:

this.onRunStart = function(browsers) {
suites = Object.create(null);
xml = builder.create('testsuites');

So there's probably an opportunity there for further patches.