feat(config): add support for TypeScript #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else if (fs.existsSync('./.config/karma.conf.js')) { | ||
| configFile = './.config/karma.conf.js' | ||
| } else if (fs.existsSync('./.config/karma.conf.coffee')) { | ||
| configFile = './.config/karma.conf.coffee' | ||
| } else if (fs.existsSync('./config/karma.conf.ts')) { |
There was a problem hiding this comment.
Here should be .config not config
|
Would be good to have some test for this. |
|
Any tip as to where to look for putting a test? I didn't see anything for coffeescript or livescript, and the way they are set up, it may not be so simple to set up since support is checked globally. |
wesleycho
force-pushed
the
feat/typescript
branch
3 times, most recently
from
f5a8841 to
ece7d03
Compare
- Add TypeScript support for `karma.conf.ts`
wesleycho
force-pushed
the
feat/typescript
branch
from
ece7d03 to
6445310
Compare
|
Found it, added a test. I also added a config template and code to the formatters to mirror the coffeescript and livescript code, although it seems they are not used. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
karma.conf.tsThis should address #1727.