feat(middleware): added manual file type option

[josh18]

Adds a manual file type so that users can instruct Karma which method to use when loading a file without an extension (such as Google font files)

Example:

files: [
    {
        pattern: 'https://fonts.googleapis.com/icon?family=Material+Icons',
        type: 'css'
    }
]

Fix for #2824

First time working karma so let me know if there are any changes I need to make.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

[josh18]

I signed it!

[googlebot]

CLAs look good, thanks!

[dignifiedquire]

Thank you, this looks like a good idea. A couple of things

1. could you update the docs please to include this
2. lets also add a script type for script files
3. can you add some validation to the type in the pattern, such that it logs a warning on unknow types?

[josh18]

1. Sure thing
2. As this is the default is this necessary? Or are you just thinking of adding it to the validation in (3)?
3. Will do, what would I use to log it? Just something like log.warn()?

Another thing I was just thinking of is if it should be fileExt === '.css' || fileType === 'css' (can't override file extension) or (fileExt === '.css' && !fileType) || fileType === 'css' (fileType always overrides extension). This would make (2) more necessary

[appsforartists]

On line 208, scriptType should be fileType || SCRIPT_TYPE[fileExt] || 'text/javascript'. I think that would let us strip the code out of #2834 and just merge its tests.

[appsforartists]

GitHub sadly wouldn't let me comment on the correct line.

[appsforartists]

GitHub sadly wouldn't let me comment on the correct line.

[josh18]

Made some changes, let me know what you think.

• File type overrides extension
• Added script file types (including esModule)
• Added file type validation
• Added file type documentation
  • Renamed one instance of Possible values -> Possible Values for consistency
  • Removed extra white space (done automatically by my editor, not sure if you want to keep this change)

[appsforartists]

This is total bikeshedding, but this could be more simply called module. It removes the only camel-cased option, and makes the API more consistent with the browser: type: 'module'.

[josh18]

That's fine I was just copying from the previous PR but I think 'module' is better. Fixed now

[appsforartists]

Pull requests usually follow the mantra "one idea -> one PR". This correction should probably have been a separate PR.

[josh18]

Makes sense, sorry about that. Reverted now. Should I squash all my commits?

[dignifiedquire]

Thank you