Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reporter): show file path correctly when urlRoot specified #2899

Merged
merged 1 commit into from
Dec 5, 2017
Merged

fix(reporter): show file path correctly when urlRoot specified #2899

merged 1 commit into from
Dec 5, 2017
+7 −0

Conversation

outsideris
Copy link
Contributor

Handle urlRoot in paths if rulRoot specified

Closes #2897

EzraBrooks
EzraBrooks approved these changes Dec 3, 2017
View reviewed changes
Copy link
Collaborator

@EzraBrooks EzraBrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@dignifiedquire dignifiedquire merged commit f64e1e0 into karma-runner:master Dec 5, 2017
@dignifiedquire
Copy link
Member

Thank you :octocat:

@remcohaszing remcohaszing mentioned this pull request Mar 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzraBrooks EzraBrooks EzraBrooks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@outsideris @dignifiedquire @doberkofler @EzraBrooks