refactor(server): Provide file-service handlers in the root injector. #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lusarz
reviewed
Jun 14, 2018
lib/server.js
Outdated
| @@ -17,7 +17,7 @@ const constant = require('./constants') | |||
| const watcher = require('./watcher') | |||
| const plugin = require('./plugin') | |||
|
|
|||
| const createWebServer = require('./web-server').createWebServer | |||
| const {createWebServer, createServeFile, createServeStaticFile, createFilesPromise} = require('./web-server') | |||
There was a problem hiding this comment.
Object destructuring not works on Node 4 - it's reason why build fails
johnjbarton
force-pushed
the
middleware-handlers
branch
from
06bb9a1 to
ae1fcc7
Compare
|
Ok thanks, fixed, tests pass. |
lusarz
approved these changes
Jun 15, 2018
lib/web-server.js
Outdated
| createWebServer.$inject = ['injector', 'config'] | ||
|
|
||
| module.exports = { | ||
| 'createWebServer': createWebServer, |
There was a problem hiding this comment.
It may be write simpler:
module.exports = {
createWebServer,
createServeFile,
createServeStaticFile,
createFilesPromise
}
By removing the creation of file-service handlers from the webserver, we create functions with better focus and we allow the file-service handlers to be used in beforeMiddlewaare. The only cost is that these objects are now visible to all modules rather than being private to webserver. The potential for collision seems small.
johnjbarton
force-pushed
the
middleware-handlers
branch
from
ae1fcc7 to
d196a0f
Compare
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing the creation of file-service handlers from the webserver, we create functions with better
focus and we allow the file-service handlers to be used in beforeMiddlewaare. The only cost is that these objects are now visible to all modules rather than being private to webserver. The potential for collision seems small.