Update this reference to self

[Itee]

Hi there,

In this._execCommand at line 73 the this keyword is use instead of self. In case of _execCommand override or external call, this will be undefined.

This proposal just fix that.

Check that your description matches the automatic change-log format:
http://karma-runner.github.io/2.0/dev/git-commit-msg.html
then delete this reminder.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[Itee]

I signed it!

[googlebot]

CLAs look good, thanks!

[lusarz]

@Itee thanks for pull request. Would you mind to update commit message ? Karma use validate-commit-msg style for that. My proposition is:

fix(launcher): update this reference to self

[lusarz]

@devoto13, @johnjbarton
What do you thinks about that ? I did something opposite here:
#3157

[devoto13]

Consider this example: https://jsfiddle.net/devoto13/1ptvhgxn/

Apparently the only case, where it has incorrect this is when method is passed as callback by reference (i.e. .then(myClass.myMethod)) or similar, which is ultimately shooting yourself in the foot. So I think your (@lusarz's) way is good as long as we (and consumers) avoid this pattern.

But maybe I'm missing something. @Itee can you provide a more complete example of when this breaks?

[devoto13]

But note that changes from self to this can potentially be breaking to the third-party code, which uses the mentioned pattern, so should probably go into a major version.

[lusarz]

Thanks @devoto13 for great input - I'll analyze your example more precisely tomorrow, but I think I know what you mean.

That's true - it would be better to release major version with these changes

Need more investigation

[johnjbarton]

Sorry this did not work out. I'm going to close a lot of older pull requests as the source code has changed a lot over the last year.
Thanks!