refactor(watcher): Make watcher injectable to support 3rd-party watchers #3254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Over the years, there has been several suggestions to make the default watcher in Karma (that uses chokidar) dependency injectable so that Karma could work well with third-party watchers. Prior issues: 1. karma-runner#1468 2. karma-runner#2895 Candidate third-party watchers include: 1. Watcher for Broccoli 2. Watcher for Bazel 3. Watcher for Blaze (used internally at Google) This commit makes the change to allow other Karma plugins to specify the 'watcher' value in the di system and Karma would use the supplied watcher instead.
johnjbarton
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the years, there has been several suggestions to make the default
watcher in Karma (that uses chokidar) dependency injectable so that
Karma could work well with third-party watchers.
Prior issues:
Candidate third-party watchers include:
This commit makes the change to allow other Karma plugins to specify the
'watcher' value in the di system and Karma would use the supplied
watcher instead.