fix(coverage): depend on a modern version of istanbul #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.1.22 has function coverage issues fixed in 0.1.40; use fuzzy version matching 0.1.22: http://bl.ocks.org/johan/raw/5942388/11133099070d95c2f2d36e9f3570881888a7af1e/given.js.html 0.1.40: http://bl.ocks.org/johan/raw/5942446/bb1ce82c73451b7cda711cd60d6984748c15d6c1/given.js.html
|
The bad/good example difference is best seen at lines 197 onwards, where the functions are marked unvisited in 0.1.22 despite having been called numerous times. Line coverage reports were off too. The karma-coverage package already uses fuzzy version dependencies, so nothing to fix there. |
|
@johan can you please change the commit msg to |
|
Merged as 9f3688e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.1.22 has function coverage issues fixed in 0.1.40; use fuzzy version matching
0.1.22: http://bl.ocks.org/johan/raw/5942388/11133099070d95c2f2d36e9f3570881888a7af1e/given.js.html
0.1.40: http://bl.ocks.org/johan/raw/5942446/bb1ce82c73451b7cda711cd60d6984748c15d6c1/given.js.html