-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes display of application when running tests. #714
Conversation
This is just a temporary workaround to not break the WebStorm plugin.
Hmm, travis ci failed with this PR - but I just added some css.. INFO [Firefox 19.0.0 (Linux)]: Connected on socket XAdeFD0W3OZgqKJ0WCAB |
Thank you Vojta |
+1 Chrome is fine, but Firefox needs this patch. |
Is it possible to push angabriel@4d77c49 as it fixes the problem for firefox? |
@angabriel Any chance you can rebase your two commits onto the latest master and squash them into one? |
Hi Friedel, hmm i think rebasing is a bad idea as those changes were pushed to remote already.. Whats the benefit to squash these two tiny commits into one? |
@angabriel I meant rebasing onto the latest version of master, as there are merge conflicts atm and this gives a nice clean history. Regarding the remote location you can use a force push to overwrite the remote version with the local version. |
already spent too much time on this. Actually whole sense of this PR was to add one single word to
perhaps you can commit this one-liner straight to master and i close this PR and maybe this repo. |
Fix based on PR karma-runner#714.
Done in #786 |
+1 Weltklasse, thx :) |
Fix based on PR karma-runner#714.
iframe did not use full height