-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to Specify Extra Volumes and Volume Mounts for Karmada API Server Component #5509
Support to Specify Extra Volumes and Volume Mounts for Karmada API Server Component #5509
Conversation
72d927b
to
f2f57c1
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5509 +/- ##
==========================================
+ Coverage 32.32% 33.86% +1.53%
==========================================
Files 643 643
Lines 44445 44509 +64
==========================================
+ Hits 14368 15071 +703
+ Misses 28985 28288 -697
- Partials 1092 1150 +58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me, just give another look at the field names that I mentioned on #5276 (comment).
f2f57c1
to
e978828
Compare
Signed-off-by: Joe Nathan Abellard <[email protected]> Initial structure Signed-off-by: Joe Nathan Abellard <[email protected]> Update api Signed-off-by: Joe Nathan Abellard <[email protected]> Update api Signed-off-by: Joe Nathan Abellard <[email protected]>
e978828
to
c45b817
Compare
Just pushed some changes to address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Today, when creating a Karmada instance to be managed by the Karmada operator, it's possible to specify extra args for the control plane components. However, it's not possible to specify extra volumes and volume mounts. This feature request is for providing the ability to specify extra volumes and volume mounts for the Karmada components.
Why is this needed:
At Bloomberg, we're currently building a managed Karmada platform and want to use the Karmada operator to manage the entire lifecycle of managed Karmada instances. We have tenants who have requirements such as the following:
Given that it's already possible to specify extra args for components like the API server, having the ability to also specify extra volumes and volume mounts will enable those use cases.
Which issue(s) this PR fixes:
Fixes #5272
Special notes for your reviewer:
Does this PR introduce a user-facing change?: