-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mTLS Configuration for Karmada Scheduler & Descheduler Components #5546
Fix mTLS Configuration for Karmada Scheduler & Descheduler Components #5546
Conversation
…escheduler Components Signed-off-by: Joe Nathan Abellard <[email protected]>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5546 +/- ##
==========================================
- Coverage 34.14% 34.13% -0.01%
==========================================
Files 643 643
Lines 44509 44511 +2
==========================================
- Hits 15197 15196 -1
- Misses 28156 28159 +3
Partials 1156 1156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
seems like same PR as #5519 |
Yeah, We try to fix this issue in #5519; you can track it there @jabellard . |
/lgtm We can have both of them. @jabellard I added a release note on this PR and we will backport this to release-1.11. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…5546-upstream-release-1.11 Automated cherry pick of #5546: Set Karmada Cert Secret Used For Configurating mTLS for
What type of PR is this?
/kind bug
What this PR does / why we need it:
A recent change introduced new flags for configuring mTLS for the Karmada Scheduler & Descheduler components. As such, the manifest templates for those components were changed accordingly to reflect the new change. Configuration of the new flags now require that a volume be mounted to use as the source of the TLS data. However, it looks like there's one more change required that was missed.
Which issue(s) this PR fixes:
Fixes #5545
Special notes for your reviewer:
Does this PR introduce a user-facing change?: