Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup csrapproving controller from kube-controller-manager #5874

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

zhzhuang-zju
Copy link
Contributor

@zhzhuang-zju zhzhuang-zju commented Nov 25, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
agentcsrapproving controller is introduced in #5825, from now on, registering member clusters with PULL mode using karmadactl register no longer depends on the csrapproving controller.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 25, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.20%. Comparing base (88c3e44) to head (3c91c7d).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/karmadactl/register/register.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5874   +/-   ##
=======================================
  Coverage   46.20%   46.20%           
=======================================
  Files         663      663           
  Lines       54580    54580           
=======================================
+ Hits        25218    25221    +3     
+ Misses      27739    27737    -2     
+ Partials     1623     1622    -1     
Flag Coverage Δ
unittests 46.20% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@zhzhuang-zju
Copy link
Contributor Author

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, otherwise LGTM.

@zhzhuang-zju zhzhuang-zju changed the title remove csrapproving, csrcleaner and csrsigning controller remove csrapproving and use agentcsrapproving controller instead Nov 25, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle cleanup csrapproving controller from kube-controller-manager

@karmada-bot karmada-bot changed the title remove csrapproving and use agentcsrapproving controller instead cleanup csrapproving controller from kube-controller-manager Nov 25, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@RainbowMango RainbowMango added this to the v1.12 milestone Nov 25, 2024
@karmada-bot karmada-bot merged commit 9267eae into karmada-io:master Nov 25, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants