Disable cluster failover by default which should be explicitly enabled by administrators after a fully evaluation #5941
Conversation
…d by administrators after a fully evaluation. Signed-off-by: RainbowMango <[email protected]>
karmada-bot
added
the
size/XL
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release-1.11 #5941 +/- ##
================================================
+ Coverage 30.97% 31.45% +0.48%
================================================
Files 644 644
Lines 54283 54280 -3
================================================
+ Hits 16813 17074 +261
+ Misses 36438 36134 -304
- Partials 1032 1072 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| if !features.FeatureGate.Enabled(features.Failover) { | ||
| return false, nil | ||
| } |
There was a problem hiding this comment.
It makes sense to me that this patch won't affect users who are using application failover.
There was a problem hiding this comment.
yes, it makes sense.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Cherry pick of #5899 on release-1.11.
For details on the cherry pick process, see the cherry pick requests page.