Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #6065: fix: resourceregistry merge the same cluster gvk's namespace #6102

Conversation

JimDevil
Copy link
Contributor

@JimDevil JimDevil commented Feb 8, 2025

Cherry pick of #6065 on release-1.10.
#6065: fix: resourceregistry merge the same cluster gvk's namespace
For details on the cherry pick process, see the cherry pick requests page.

`karmada-search`: Fixed the issue that namespaces in different ResourceRegistry might be overwritten.

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 8, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 68.96552% with 9 lines in your changes missing coverage. Please review.

Project coverage is 50.91%. Comparing base (908c04b) to head (64192b4).

Files with missing lines Patch % Lines
pkg/search/proxy/controller.go 66.66% 4 Missing and 2 partials ⚠️
pkg/search/proxy/store/util.go 72.72% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10    #6102      +/-   ##
================================================
+ Coverage         50.90%   50.91%   +0.01%     
================================================
  Files               265      265              
  Lines             26745    26762      +17     
================================================
+ Hits              13614    13627      +13     
- Misses            12353    12356       +3     
- Partials            778      779       +1     
Flag Coverage Δ
unittests 50.91% <68.96%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango RainbowMango mentioned this pull request Jan 22, 2025
4 tasks
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2025
@karmada-bot karmada-bot merged commit 5aed479 into karmada-io:release-1.10 Feb 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants