Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #6157, #6161: fix(detector): Fixed the issue where the detector unnecessary updates for RB issue. #6167

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Feb 28, 2025

Cherry pick of #6157 #6161 on release-1.12.
#6157: fix(detector): fix new binding object
#6161: fix(detector): fix new binding object
For details on the cherry pick process, see the cherry pick requests page.

`karmada-controller-manager`: Fixed the issue where the `detector` unnecessary updates for RB issue.

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 28, 2025
@XiShanYongYe-Chang XiShanYongYe-Chang mentioned this pull request Feb 28, 2025
3 tasks
@XiShanYongYe-Chang XiShanYongYe-Chang changed the title Automated cherry pick of #6157: fix(detector): fix new binding object #6161: fix(detector): fix new binding object Automated cherry pick of #6157, #6161: fix(detector): Fix the invalid behavior in the detector to determine whether the binding object needs to be updated Feb 28, 2025
@XiShanYongYe-Chang XiShanYongYe-Chang changed the title Automated cherry pick of #6157, #6161: fix(detector): Fix the invalid behavior in the detector to determine whether the binding object needs to be updated Automated cherry pick of #6157, #6161: fix(detector): Fixed the issue where the detector unnecessary updates for RB issue. Feb 28, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.54%. Comparing base (265eb0b) to head (0ea2940).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.12    #6167      +/-   ##
================================================
+ Coverage         46.53%   46.54%   +0.01%     
================================================
  Files               664      664              
  Lines             54810    54824      +14     
================================================
+ Hits              25504    25520      +16     
+ Misses            27678    27677       -1     
+ Partials           1628     1627       -1     
Flag Coverage Δ
unittests 46.54% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2025
@karmada-bot karmada-bot merged commit 013a914 into karmada-io:release-1.12 Feb 28, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants