Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize the naming of karmada secrets #6178

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

husnialhamdani
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #6051

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lonelycz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 1, 2025
@husnialhamdani
Copy link
Contributor Author

actually, in this sub task we need to do just two things:

  1. the yaml manifest of each component is listed in operator/pkg/controlplane/ directory, we shall improve the yaml manifest according to above example
  2. the certificate is generated in NewCertTask and stored to secret in NewUploadCertsTask, we will rename the secret and the field according to above new naming convention.

Am I doing right, so far?
At least for point number 1

@chaosi-zju

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.95%. Comparing base (3b6c0e0) to head (b82a6a2).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6178      +/-   ##
==========================================
- Coverage   47.95%   47.95%   -0.01%     
==========================================
  Files         674      674              
  Lines       55841    55841              
==========================================
- Hits        26781    26776       -5     
- Misses      27311    27315       +4     
- Partials     1749     1750       +1     
Flag Coverage Δ
unittests 47.95% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Umbrella] [Karmada config && certificates] secret and path naming convention
3 participants