Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo equivalence - tmp #730

Closed
wants to merge 26 commits into from

Conversation

gordicaleksa
Copy link
Contributor

cc: @karpathy

here is the minimal change on top of my PR that gives equivalent code to nano llama 3 reference.py from commit karpathy/nano-llama31@d0dfb06

Steps:

  1. Check out this PR
  2. Check out the commit I linked above from nano llama 3 (the only thing you've introduced since is passing in a generator, so functionality-wise this is an equivalent commit)
  3. Comment out nn.Linear & nn.Embedding's reset params function in PyTorch constructor
  4. Run and see same samples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant