Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support packaging #238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kurman
Copy link

@kurman kurman commented Apr 7, 2023

  1. Load configurator.py relative to training script
    ===================================================
    Right now configurator.py is loaded from CWD, however training script can be invoked as a python module. We can either convert configurator to a module or load it relative to train.py script. The latter is simpler and works.

  2. Allow explicit dataset path arguments
    ========================================
    Similar to previous issue, dataset files may exist in other location relative to CWD so we can add path parameters that can be overridden using existing configuration mechanism

…cript 2) allow explicit dataset path arguments
@karpathy
Copy link
Owner

This commit does two things: the thing you mentioned but also it introduces new variables for train/val paths...

gkielian added a commit to gkielian/ReaLLMASIC_nanogpt that referenced this pull request Aug 22, 2024
gkielian added a commit to gkielian/ReaLLMASIC_nanogpt that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants