Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

race condition in context.py #109

Closed
eirrgang opened this issue Jun 7, 2018 · 0 comments
Closed

race condition in context.py #109

eirrgang opened this issue Jun 7, 2018 · 0 comments
Assignees
Labels

Comments

@eirrgang
Copy link
Collaborator

eirrgang commented Jun 7, 2018

Since there is not a filter to only create a working directory on the rank that needs it, there is a race condition between checking for the existence of a directory and attempting to create it from Python (which does not have an equivalent of mkdir -p).

I can fix the race condition now, but this may indicate a need for an additional element of the Context API to perform infrastructure tasks redundantly or not on each worker depending on the Context. However, in the case of working directories and file paths, the need does not exist because of the way we will be managing data placement in a near future release. ref #96 and #79

@eirrgang eirrgang added the bug label Jun 7, 2018
@eirrgang eirrgang self-assigned this Jun 7, 2018
eirrgang added a commit to eirrgang/gmxapi that referenced this issue Jun 7, 2018
Create only the new directory we are going to use on the current rank.
Restore current directory to original state at end of session.
eirrgang added a commit to eirrgang/gmxapi that referenced this issue Jun 7, 2018
Create only the new directory we are going to use on the current rank.
Restore current directory to original state at end of session.
eirrgang added a commit that referenced this issue Jun 7, 2018
Create only the new directory we are going to use on the current rank.
Restore current directory to original state at end of session.
@eirrgang eirrgang closed this as completed Jun 7, 2018
eirrgang added a commit that referenced this issue Jul 24, 2018
Create only the new directory we are going to use on the current rank.
Restore current directory to original state at end of session.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant