Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to CMake-driven build and install #26

Closed
eirrgang opened this issue Apr 25, 2018 · 2 comments
Closed

Move to CMake-driven build and install #26

eirrgang opened this issue Apr 25, 2018 · 2 comments
Assignees
@eirrgang
Labels
duplicate

Comments

@eirrgang
Copy link
Collaborator

Pip is not giving us more ease-of-installation than it is costing, and pip 10 broke our builds. We are already wrapping CMake with setuptools, so maintaining pip / setup.py as the primary install method is neither sensible nor worthwhile. We may still want a thinner setup.py wrapper for readthedocs builds or something, but we should not use it for dependency resolution, compiler selection, etc. All that is really required is to use the setuptools Python package in a CMake script to locate the preferred installation directory for a given python environment.
@eirrgang
Copy link
Collaborator Author

pip 10.0.1 may have resolved the issue, but I don't know if that matters.

@eirrgang eirrgang self-assigned this Apr 29, 2018
@eirrgang
Copy link
Collaborator Author

duplicate of #60

eirrgang pushed a commit that referenced this issue Mar 16, 2023
@al42and @acmnpv
oneAPI: Add -fsycl-device-code-split to linker
9377b8d 
Refactoring of SYCL compiler flags in dea311a (!2841) caused
the `-fsycl-device-code-split=per_kernel` flag to be only used during
the compilation, not linking. As a result, the flag did not have any effect, 
and all the kernels were JITed every time, significantly increasing
the initialization time.

Today's nightly: https://gitlab.com/gromacs/gromacs/-/jobs/2817361699

```
 1/84 Test  #1: GmxapiExternalInterfaceTests ..............   Passed   23.85 sec
26/84 Test #26: EwaldUnitTests ............................***Timeout  30.06 sec
64/84 Test #64: MdrunTestsOneRank .........................   Passed   77.39 sec
```

After this MR: https://gitlab.com/gromacs/gromacs/-/jobs/2819696665

```
 1/84 Test  #1: GmxapiExternalInterfaceTests ..............   Passed    2.81 sec
26/84 Test #26: EwaldUnitTests ............................   Passed    6.86 sec
64/84 Test #64: MdrunTestsOneRank .........................   Passed    2.23 sec
```

Fixes #4551

Closes #4551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eirrgang eirrgang

Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eirrgang