Skipping directories that fail to be read when walking #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezanzeb
force-pushed
the
skip-walking-failures
branch
from
dc66960 to
b536683
Compare
sezanzeb
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no indicator in the UI yet, but at least it won't crash completely when a single directory fails to be read.
This was is caused by folders being owned by root.
This does not happen in the batch mode which uses
os.walk, only gnomes file utilities have this problem.https://bugs.launchpad.net/soundconverter/+bug/2006988
I also split the integration.py test file into two, one for batch and one for gui