Fix the issue with empty array replacement

Prior to this change, if there is only one element in an array that is a reference to an empty array, the original array becomes nil after replacement, but it should be an empty array instead of nil. Fixes tektoncd#5149 Signed-off-by: Vincent Demeester <[email protected]>
katanomi · Sep 2, 2022 · a36d154 · a36d154
1 parent dae5005
commit a36d154
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/apis/pipeline/v1beta1/param_types_test.go b/pkg/apis/pipeline/v1beta1/param_types_test.go
@@ -202,7 +202,11 @@ func TestArrayOrString_ApplyReplacements(t *testing.T) {
 	}, {
 		name: "empty array replacement without extra elements",
 		args: args{
-			input:             v1beta1.NewArrayOrString("$(arraykey)"),
+			// input:             v1beta1.NewArrayOrString("$(arraykey)"),
+			input: &v1beta1.ArrayOrString{
+				Type:     v1beta1.ParamTypeArray,
+				ArrayVal: []string{"$(arraykey)"},
+			},
 			arrayReplacements: map[string][]string{"arraykey": {}},
 		},
 		expectedOutput: &v1beta1.ArrayOrString{Type: v1beta1.ParamTypeArray, ArrayVal: []string{}},