Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add methods setCurrentTime #1046

Merged
merged 9 commits into from
Apr 18, 2017
Merged

add methods setCurrentTime #1046

merged 9 commits into from
Apr 18, 2017

Conversation

entonbiba
Copy link
Contributor

@entonbiba entonbiba commented Mar 17, 2017 •
edited
Loading

add methods
setCurrentTime(seconds)
sets the current time in seconds

#1039

@entonbiba entonbiba mentioned this pull request Mar 17, 2017
Closed
@entonbiba entonbiba changed the title add method setCurrentTime, setCurrentTimeBetween add methods setCurrentTime, setCurrentTimeBetween Mar 17, 2017
@mspae
Copy link
Contributor

mspae commented Mar 20, 2017

So just to make sure I understand you correctly: This is basically what the play function does, just without actually starting playback, right? – I don't quite get a use case for setCurrentTimeBetween – This sets the playback position to a point in the middle between two offsets, correct?

@mspae
Copy link
Contributor

mspae commented Mar 20, 2017

Or in other words it does what seekTo does, Just with a percentual Value.

@entonbiba
Copy link
Contributor Author

@mspae yes, it sets the current time between the provided start and end seconds.

thijstriemstra
thijstriemstra suggested changes Apr 10, 2017
View reviewed changes
Copy link
Contributor

@thijstriemstra thijstriemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this but leave the setCurrentTimeBetween out and open a separate PR for that later.

@entonbiba
Copy link
Contributor Author

entonbiba commented Apr 17, 2017 •
edited
Loading

@thijstriemstra done, I'll open another pr for the setCurrentTimeBetween.

@entonbiba entonbiba changed the title add methods setCurrentTime, setCurrentTimeBetween add methods setCurrentTime Apr 17, 2017
@thijstriemstra thijstriemstra merged commit ffef86e into master Apr 18, 2017
@thijstriemstra thijstriemstra deleted the entonbiba-patch-setCurrentTime branch April 18, 2017 13:25
@mattdiamond
Copy link

I think there may have been a slight typo in the setCurrentTime function... just noticed it when I was browsing the code to learn more about the library. I left a comment on ffef86e.

@thijstriemstra
Copy link
Contributor

@mattdiamond can you open a PR for that? thanks.

mspae pushed a commit to mspae/wavesurfer.js that referenced this pull request Aug 18, 2017
@entonbiba @mspae
add method setCurrentTime (katspaugh#1046)
e2dcbad 
* add method setCurrentTime
mspae pushed a commit that referenced this pull request Aug 19, 2017
@entonbiba @mspae
add method setCurrentTime (#1046)
8efee7f 
* add method setCurrentTime
@roboswank roboswank mentioned this pull request Jan 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijstriemstra thijstriemstra thijstriemstra approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@entonbiba @mspae @mattdiamond @thijstriemstra