timeline plugin: Round to milliseconds #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had problems with labels being things like "0.99999999999999999999" which may be extra precized, but are far from readable. Also, I think milliseconds precision is far from enough. :P
|
@X-Raym what kind of problem did you have with the precise value? |
katspaugh
approved these changes
May 13, 2017
|
Yes, I guess those long fractions can occur due to arithmetic operations when calculating the seconds. LGTM, thanks! |
thijstriemstra
changed the title
|
@thijstriemstra Thanks ! |
|
@entonbiba For info, here was the problem: |
mspae
pushed a commit
to mspae/wavesurfer.js
that referenced
this pull request
Aug 18, 2017
timeline plugin: Round to milliseconds
mspae
pushed a commit
that referenced
this pull request
Aug 19, 2017
timeline plugin: Round to milliseconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had problems with labels being things like "0.99999999999999999999" which may be extra precized, but are far from readable. Also, I think milliseconds precision is far from enough. :P
Hey, thank you for contributing to wavesurfer.js!
To review/merge open PRs it is very helpful to know as much as possible about the changes which are being introduced. Reviewing PRs is very time consuming, please be patient, it can take some time to do properly.
Title: Please make sure the name of your PR is as descriptive as possible (Describe the feature that is introduced or the bug that is being fixed).
Please make sure you provide the information below:
Short description of changes:
Breaking in the external API:
Breaking changes in the internal API:
Todos/Notes:
Related Issues and other PRs: