Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Simple tty compatible spinner #8

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

WatskeBart
Copy link
Contributor

Added a tty compatible spinner.

spinner

@kattouf
Copy link
Owner

kattouf commented Jan 8, 2025

Thank you for the pull request, it looks nice!
Apologies, I don’t have a contribution guide yet, so I’ll mention it here: please add the prefix feat: to the pull request title. This is required for generating release changelogs.

After merging, I’ll update the documentation with the new animation type and a GIF when possible, and I’ll publish a release.

@WatskeBart WatskeBart changed the title Simple tty compatible spinner feat: Simple tty compatible spinner Jan 8, 2025
@WatskeBart
Copy link
Contributor Author

Thank you for the pull request, it looks nice! Apologies, I don’t have a contribution guide yet, so I’ll mention it here: please add the prefix feat: to the pull request title. This is required for generating release changelogs.

After merging, I’ll update the documentation with the new animation type and a GIF when possible, and I’ll publish a release.

Added the feat:

@kattouf kattouf merged commit 4052967 into kattouf:main Jan 9, 2025
5 checks passed
@kattouf
Copy link
Owner

kattouf commented Jan 9, 2025

@WatskeBart thanks for your contribution 🤝

@WatskeBart WatskeBart deleted the tty-spinner branch January 9, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants