Skip to content

Commit

Permalink
Increase version to 1.0.0-beta1 (elastic#299)
Browse files Browse the repository at this point in the history
* Increase version to 1.0.0-beta1

* Set InformationalVersion and report that as agent version
  • Loading branch information
gregkalapos authored Jun 18, 2019
1 parent 9c6093f commit d19f7a4
Show file tree
Hide file tree
Showing 7 changed files with 22 additions and 20 deletions.
8 changes: 4 additions & 4 deletions src/Elastic.Apm.All/Elastic.Apm.All.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
<TargetFramework>netstandard2.0</TargetFramework>
<AssemblyName>Elastic.Apm.All</AssemblyName>
<RootNamespace>Elastic.Apm.All</RootNamespace>
<AssemblyVersion>0.0.2.0</AssemblyVersion>
<InformationalVersion>0.0.2.0</InformationalVersion>
<FileVersion>0.0.2.0</FileVersion>
<AssemblyVersion>1.0.0</AssemblyVersion>
<InformationalVersion>1.0.0-beta1</InformationalVersion>
<FileVersion>1.0.0</FileVersion>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>..\..\build\elasticapm.snk</AssemblyOriginatorKeyFile>
<DelaySign>false</DelaySign>
<PackageVersion>0.0.2.0-alpha</PackageVersion>
<PackageVersion>1.0.0-beta1</PackageVersion>
<Authors>Elastic and contributors</Authors>
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<PackageId>Elastic.Apm.All</PackageId>
Expand Down
8 changes: 4 additions & 4 deletions src/Elastic.Apm.AspNetCore/Elastic.Apm.AspNetCore.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<AssemblyName>Elastic.Apm.AspNetCore</AssemblyName>
<AssemblyVersion>0.0.2.0</AssemblyVersion>
<InformationalVersion>0.0.2.0</InformationalVersion>
<FileVersion>0.0.2.0</FileVersion>
<AssemblyVersion>1.0.0</AssemblyVersion>
<InformationalVersion>1.0.0-beta1</InformationalVersion>
<FileVersion>1.0.0</FileVersion>
<RootNamespace>Elastic.Apm.AspNetCore</RootNamespace>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>..\..\build\elasticapm.snk</AssemblyOriginatorKeyFile>
<DelaySign>false</DelaySign>
<PackageVersion>0.0.2.0-alpha</PackageVersion>
<PackageVersion>1.0.0-beta1</PackageVersion>
<Authors>Elastic and contributors</Authors>
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<PackageId>Elastic.Apm.AspNetCore</PackageId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
<TargetFramework>netstandard2.0</TargetFramework>
<RootNamespace>Elastic.Apm.EntityFrameworkCore</RootNamespace>
<AssemblyName>Elastic.Apm.EntityFrameworkCore</AssemblyName>
<AssemblyVersion>0.0.2.0</AssemblyVersion>
<InformationalVersion>0.0.2.0</InformationalVersion>
<FileVersion>0.0.2.0</FileVersion>
<AssemblyVersion>1.0.0</AssemblyVersion>
<InformationalVersion>1.0.0-beta1</InformationalVersion>
<FileVersion>1.0.0</FileVersion>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>..\..\build\elasticapm.snk</AssemblyOriginatorKeyFile>
<DelaySign>false</DelaySign>
<PackageVersion>0.0.2.0-alpha</PackageVersion>
<PackageVersion>1.0.0-beta1</PackageVersion>
<Authors>Elastic and contributors</Authors>
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<PackageId>Elastic.Apm.EntityFrameworkCore</PackageId>
Expand Down
6 changes: 4 additions & 2 deletions src/Elastic.Apm/Api/Service.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
using Elastic.Apm.Config;
using System.Diagnostics;
using System.Reflection;
using Elastic.Apm.Config;

namespace Elastic.Apm.Api
{
Expand All @@ -18,7 +20,7 @@ internal static Service GetDefaultService(IConfigurationReader configurationRead
Agent = new AgentC
{
Name = Consts.AgentName,
Version = typeof(Agent).Assembly.GetName().Version?.ToString() ?? "n/a"
Version = typeof(Agent).Assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>().InformationalVersion
}
};

Expand Down
8 changes: 4 additions & 4 deletions src/Elastic.Apm/Elastic.Apm.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
<PropertyGroup>
<RootNamespace>Elastic.Apm</RootNamespace>
<AssemblyName>Elastic.Apm</AssemblyName>
<AssemblyVersion>0.0.2.0</AssemblyVersion>
<InformationalVersion>0.0.2.0</InformationalVersion>
<FileVersion>0.0.2.0</FileVersion>
<AssemblyVersion>1.0.0</AssemblyVersion>
<InformationalVersion>1.0.0-beta1</InformationalVersion>
<FileVersion>1.0.0</FileVersion>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>..\..\build\elasticapm.snk</AssemblyOriginatorKeyFile>
<DelaySign>false</DelaySign>
<PackageVersion>0.0.2.0-alpha</PackageVersion>
<PackageVersion>1.0.0-beta1</PackageVersion>
<Authors>Elastic and contributors</Authors>
<PackageId>Elastic.Apm</PackageId>
<copyright>2019 Elasticsearch BV</copyright>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public async Task HomeSimplePageTransactionTest()
.And.NotBe(ConfigConsts.DefaultValues.UnknownServiceName);

_agent.Service.Agent.Name.Should().Be(Elastic.Apm.Consts.AgentName);
var apmVersion = Assembly.Load("Elastic.Apm").GetName().Version.ToString();
var apmVersion = typeof(Agent).Assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>().InformationalVersion;
_agent.Service.Agent.Version.Should().Be(apmVersion);

_agent.Service.Framework.Name.Should().Be("ASP.NET Core");
Expand Down
2 changes: 1 addition & 1 deletion test/Elastic.Apm.Tests/BasicAgentTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public void AgentVersion()
using (var agent = new ApmAgent(new TestAgentComponents(payloadSender: payloadSender)))
{
agent.Tracer.CaptureTransaction("TestName", "TestType", () => { Thread.Sleep(5); });
agent.Service.Agent.Version.Should().Be(Assembly.Load("Elastic.Apm").GetName().Version.ToString());
agent.Service.Agent.Version.Should().Be(typeof(Agent).Assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>().InformationalVersion);
}
}

Expand Down

0 comments on commit d19f7a4

Please sign in to comment.