Skip to content
This repository has been archived by the owner on Dec 31, 2024. It is now read-only.

fix(datetime): missing options from $d supports key format object (#1502) #1571

Closed
5 tasks done
majdkhasib opened this issue Oct 31, 2022 · 3 comments
Closed
5 tasks done

fix(datetime): missing options from $d supports key format object (#1502) #1571

majdkhasib opened this issue Oct 31, 2022 · 3 comments
Labels
good first issue Good for newcomers Status: PR Welcome Welcome to Pull Request

Comments

@majdkhasib
Copy link
Contributor

Reporting a bug?

This feature misses some options:
timeZone:
hour12:
hourCycle:
formatMatcher:

Expected behavior

Adding the args will change the output

Reproduction

adding the args

System Info

Nth

Screenshot

No response

Additional context

No response

Validations
@majdkhasib majdkhasib added the Status: Review Needed Request for review comments label Oct 31, 2022
@kazupon kazupon added good first issue Good for newcomers Status: PR Welcome Welcome to Pull Request and removed Status: Review Needed Request for review comments labels Oct 31, 2022
majdkhasib added a commit to majdkhasib/vue-i18n that referenced this issue Oct 31, 2022
@majdkhasib
fix(datetime): support all key format object (kazupon#1571)
8f53334
@majdkhasib
Copy link
Contributor Author

@kazupon
PR is added here

kazupon pushed a commit that referenced this issue Oct 31, 2022
@majdkhasib
fix(datetime): support all key format object (#1571) (#1572)
5ef6dc3
@kazupon
Copy link
Owner

kazupon commented Oct 31, 2022

I've just released v8.28.1
Please check it!

@kazupon kazupon closed this as completed Oct 31, 2022
@majdkhasib
Copy link
Contributor Author

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers Status: PR Welcome Welcome to Pull Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kazupon @majdkhasib