The plug-in is not compatible with vscode-neovim

[echaya]

Hi, I've been trying out vscode-neovim lately and seems it is not fully compatible with python-indent

The exact issue:

when pressing o in normal mode, it shall insert a line below the current cursor line. However with python-indent enabled, it enters insert mode and leave the cursor in the same line.

I'm not entirely sure it is a python-indent issue or from vscode-neovim. But i have to give up python-indent for now as I'm migrating most workflow on vscode nowadays.

Let me know if additional info is needed on the bug.

[kbrose]

Thanks for the note @echaya.

I'm hoping this will be a simple update to the condition here: https://github.com/kbrose/vsc-python-indent/blob/master/package.json#L46 (&& vim.mode =~ /(Insert|Replace|SurroundInputMode)/). See #10 for more information

I've special cased the vim plugin, but perhaps the neovim plugin also needs to be included. I hope that they enable filtering in a similar way to the vim plugin. I'll try to dig in at some point in the near future.

[echaya]

thanks for the prompt reply @kbrose and looking forward to the update!

maybe neovim.mode == insert will just do the trick.

[kbrose]

Just double checking, is this the right extension? https://marketplace.visualstudio.com/items?itemName=asvetliakov.vscode-neovim

[kbrose]

@echaya is normal mode different than insert mode? (I don't use vim.)

If the python-indent extension only activated in insert mode, would that be correct behavior?

[echaya]

Just double checking, is this the right extension? https://marketplace.visualstudio.com/items?itemName=asvetliakov.vscode-neovim

It is the right plug-in.

@echaya is normal mode different than insert mode? (I don't use vim.)

If the python-indent extension only activated in insert mode, would that be correct behavior?

Insert mode is the mode people typing out most of the code while normal mode is to move around the cursor and make small changes on existing text (or going into insert mode for big changes). So i guess it makes sense to only enable python-indent during the insert mode.

[kbrose]

@echaya can you try getting the latest version (1.14.2) and see if that fixes things?

[echaya]

it works!!! Thanks much Kevin! Best, Frederick Z. Zhang, PhD, CFA

…

On Thu, Apr 22, 2021 at 11:15 AM Kevin Rose ***@***.***> wrote: @echaya <https://github.com/echaya> can you try getting the latest version (1.14.2) and see if that fixes things? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#82 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIFK4SHPWJ3MGP2ZWZRG6EDTJ6IEPANCNFSM43JRKBNA> .