Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Redmine 4.2 #404

Merged
merged 7 commits into from
Jun 27, 2024
Merged

Support for Redmine 4.2 #404

merged 7 commits into from
Jun 27, 2024

Conversation

Art4
Copy link
Collaborator

@Art4 Art4 commented Jun 26, 2024

This PR extends the support for Redmine versions that receives security updates. Therefore I've created a new testsuite for Redmine 4.2.10. The newest version is 4.2.11, but this tag is missing on Docker Hub.

Running all behat tests now looks like this.
$ docker compose exec php composer behat
> behat --config tests/Behat/behat.yml --format progress
...................................................................... 70
...................................................................... 140
...................................................................... 210
...................................................................... 280
...................................................................... 350
...................................................................... 420
...................................................................... 490
...................................................................... 560
...................................................................... 630
...................................................................... 700
...................................................................... 770
...................................................................... 840
...................................................................... 910
...................................................................... 980
...................................................................... 1050
...................................................................... 1120
...................................................................... 1190
...................................................................... 1260
...................................................................... 1330
...................................................................... 1400
...................................................................... 1470
...................................................................... 1540
...................................................................... 1610
...................................................................... 1680
...................................................................... 1750
...................................................................... 1820
...................................................................... 1890
..........................................................

196 scenarios (196 passed)
1948 steps (1948 passed)
2m29.44s (17.15Mb)

This PR requires #403 and #402.

@Art4 Art4 added this to the v2.7.0 milestone Jun 26, 2024
@Art4 Art4 self-assigned this Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (98e72b1) to head (8c29a12).

Additional details and impacted files
@@            Coverage Diff            @@
##               v2.x     #404   +/-   ##
=========================================
  Coverage     98.47%   98.47%           
  Complexity      609      609           
=========================================
  Files            29       29           
  Lines          1841     1841           
=========================================
  Hits           1813     1813           
  Misses           28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Art4 Art4 marked this pull request as ready for review June 27, 2024 10:40
@Art4 Art4 requested a review from kbsali June 27, 2024 10:40
Copy link
Owner

@kbsali kbsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG 👏

@Art4 Art4 merged commit 31768d5 into kbsali:v2.x Jun 27, 2024
12 checks passed
@Art4 Art4 deleted the support-redmine-4.2 branch June 27, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants