Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mangle regex.match system module function #88

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 18, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #87

2. What is the scope of this PR (e.g. component or file name):

  • pkg/kube_resource/generator/generator.go
  • pkg/swagger/generator/language.go
  • pkg/swagger/generator/model.go
  • pkg/swagger/generator/structs.go
  • pkg/swagger/generator/templates/header.gotmpl
  • pkg/swagger/generator/templates/schemaexpr.gotmpl
  • pkg/swagger/generator/templates/schemavalidator.gotmpl

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • pkg/kube_resource/generator/testdata/schema_regex_attribute/servicemonitors-crd.json

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8321960192

Details

  • 49 of 53 (92.45%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 66.509%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kube_resource/generator/generator.go 0 1 0.0%
pkg/swagger/generator/model.go 31 34 91.18%
Totals Coverage Status
Change from base Build 8295304989: 0.3%
Covered Lines: 2113
Relevant Lines: 3177

💛 - Coveralls

Copy link

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit fba48bd into kcl-lang:main Mar 18, 2024
5 checks passed
@Peefy Peefy deleted the mangle-system-module-import branch March 18, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kcl import issues
3 participants