Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Override tools support import deduplication for different aliased packages. #116

Closed
Peefy opened this issue Jul 21, 2022 · 0 comments · Fixed by #120
Closed

[Enhancement] Override tools support import deduplication for different aliased packages. #116

Peefy opened this issue Jul 21, 2022 · 0 comments · Fixed by #120
Assignees
@Peefy
Labels
enhancement New feature or request tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc.
Milestone
v0.4.3 Release

Comments

@Peefy
Copy link
Contributor

Peefy commented Jul 21, 2022

Enhancement

when use override_file API, it needs to support import deduplication for different aliased packages.

  • Before override_file call with the parameter import_paths = ["pkg.to.path", "pkg.to.path as alias"]
schema Person:
    name: str
  • After override_file call
import pkg.to.path
import pkg.to.path as alias

schema Person:
    name: str
@Peefy Peefy added enhancement New feature or request tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc. labels Jul 21, 2022
@Peefy Peefy added this to the v0.4.3 Release milestone Jul 21, 2022
@Peefy Peefy self-assigned this Jul 21, 2022
@Peefy Peefy mentioned this issue Jul 25, 2022
Merged
16 tasks
@Peefy Peefy linked a pull request Jul 25, 2022 that will close this issue
refactor: support import deduplication for different aliased packages… #120
Merged
16 tasks
eminaktas pushed a commit to eminaktas/kcl that referenced this issue Oct 17, 2024
@liu-hm19
Add aws rds instance type check (kcl-lang#116)
57ed995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Peefy Peefy

Labels
enhancement New feature or request tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc.
Projects
None yet
Milestone
v0.4.3 Release
Development

Successfully merging a pull request may close this issue.

refactor: support import deduplication for different aliased packages… Peefy/KCLVM
1 participant
@Peefy