Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(compiler-base): reuse 'rustc_span' for code location. #150

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Feat(compiler-base): reuse 'rustc_span' for code location. #150

merged 1 commit into from
Aug 15, 2022

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #115

2. What is the scope of this PR (e.g. component or file name):

kclvm/compiler_base/3rdparty/rustc_span
kclvm/compiler_base/3rdparty/rustc_data_structures
kclvm/compiler_base/span

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other
  1. 'Compiler-Base' decides to reuse 'rustc_span' to describe code snippets and the location of code elements in the file.
  2. 'rustc_span' depends on 'rustc_data_structure', so we need to copy the code of these two parts at the same time.
  3. copy -r '3rdparty/rustc_span' and '3rdparty/rustc_data_structure' from 'kclvm' to 'kclvm/compiler_base'.
  4. add 'span' in 'kclvm/compiler_base' to pub use some parts of '3rdparty/rustc_span'.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

At present, the ''rustc_span'' and 'rustc_data_structure' are not used and tested separately. In the future, the methods will be individually provided according to the parts used, and tests will be provided together.

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

'Compiler-Base' decides to reuse 'rustc_span' and 'rustc_data_structure' to describe code snippets and the location of code elements in the file.
copy -r '3rdparty/rustc_span' and '3rdparty/rustc_data_structure' from 'kclvm' to 'kclvm/compiler_base'.
add 'span' in 'kclvm/compiler_base' to pub use some parts of '3rdparty/rustc_span' and '3rdparty/rustc_data_structure'.

issue #115
@zong-zhe zong-zhe added enhancement New feature or request error-handling Issues or PRs related to kcl error handling feat labels Aug 15, 2022
@zong-zhe zong-zhe added this to the v0.4.3 Release milestone Aug 15, 2022
@zong-zhe zong-zhe requested review from chai2010, Peefy, ldxdl and He1pa August 15, 2022 03:56
@zong-zhe zong-zhe self-assigned this Aug 15, 2022
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe changed the title feat(compiler-base): reuse 'rustc_span' for code location. Feat(compiler-base): reuse 'rustc_span' for code location. Aug 15, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2858351949

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 59.021%

Totals Coverage Status
Change from base Build 2858271924: -0.6%
Covered Lines: 21364
Relevant Lines: 36197

💛 - Coveralls

@ldxdl
Copy link
Contributor

ldxdl commented Aug 15, 2022

LGTM

@zong-zhe zong-zhe merged commit 83b6ad4 into kcl-lang:main Aug 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2022
@zong-zhe zong-zhe deleted the reuse-rustc-span branch August 15, 2022 06:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request error-handling Issues or PRs related to kcl error handling feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants