Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isnullish builtin function #1606

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 27, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Closes #1600

feat: add isnullish builtin function

@Peefy Peefy force-pushed the feat-isnullish-builtin-function branch from eed9922 to d1a91cf Compare August 27, 2024 04:49
@Peefy Peefy force-pushed the feat-isnullish-builtin-function branch from d1a91cf to f9d77dd Compare August 27, 2024 09:17
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit bf45c39 into kcl-lang:main Aug 27, 2024
12 checks passed
@Peefy Peefy deleted the feat-isnullish-builtin-function branch August 27, 2024 09:49
@coveralls
Copy link
Collaborator

coveralls commented Aug 27, 2024

Pull Request Test Coverage Report for Build 10575292567

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 14 (7.14%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 70.915%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/stdlib/builtin_api.rs 0 13 0.0%
Totals Coverage Status
Change from base Build 10571823119: -0.01%
Covered Lines: 51575
Relevant Lines: 72728

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add built-in is_nullable() function for None/Undefined checks
3 participants