Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: all runtime func args and kwargs #1636

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Sep 10, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • refactor: all runtime func args and kwargs

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit e3792bc into kcl-lang:main Sep 10, 2024
11 of 12 checks passed
@Peefy Peefy deleted the refactor-all-runtime-func-args branch September 10, 2024 06:01
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10786337095

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 30 of 320 (9.38%) changed or added relevant lines in 10 files are covered.
  • 36 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.1%) to 70.632%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/stdlib/builtin_api.rs 0 2 0.0%
kclvm/runtime/src/value/val_as_val.rs 0 6 0.0%
kclvm/runtime/src/json/mod.rs 7 15 46.67%
kclvm/runtime/src/value/val_args.rs 8 16 50.0%
kclvm/runtime/src/yaml/mod.rs 0 20 0.0%
kclvm/runtime/src/regex/mod.rs 4 52 7.69%
kclvm/runtime/src/units/mod.rs 0 53 0.0%
kclvm/runtime/src/net/mod.rs 0 72 0.0%
kclvm/runtime/src/math/mod.rs 10 83 12.05%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/mod.rs 1 99.06%
kclvm/runtime/src/stdlib/builtin_api.rs 1 26.51%
kclvm/runtime/src/net/mod.rs 3 0.0%
kclvm/sema/src/core/symbol.rs 3 53.21%
kclvm/runtime/src/json/mod.rs 3 32.93%
kclvm/runtime/src/units/mod.rs 3 14.98%
kclvm/runtime/src/regex/mod.rs 6 10.49%
kclvm/runtime/src/value/val_args.rs 16 50.0%
Totals Coverage Status
Change from base Build 10775589600: -0.1%
Covered Lines: 51285
Relevant Lines: 72609

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants