Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix #1776 use assert add no overhead on release version #1781

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

lwz23
Copy link
Contributor

@lwz23 lwz23 commented Dec 11, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe
Copy link
Contributor

Hi @lwz23 😄

The github action issue I have fixed in the main branch, try rebase main branch.

@lwz23
Copy link
Contributor Author

lwz23 commented Dec 11, 2024

Hi, I have rebased the branch onto main. Please let me know if there's anything else!

@coveralls
Copy link
Collaborator

coveralls commented Dec 12, 2024

Pull Request Test Coverage Report for Build 12353917993

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 70.661%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/api/utils.rs 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/advanced_resolver/node.rs 1 84.99%
kclvm/tools/src/LSP/src/state.rs 12 73.56%
Totals Coverage Status
Change from base Build 12349353137: -0.02%
Covered Lines: 52761
Relevant Lines: 74668

💛 - Coveralls

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He1pa He1pa merged commit 27a32d0 into kcl-lang:main Dec 24, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maybe unsound in c2str_vec
4 participants